Skip to content

fix(api): Return 400 for preference validation ValueErrors #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(api): Return 400 for preference validation ValueErrors #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/nurse_scheduling/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,13 @@ async def optimize_and_export_xlsx(
# User-supplied scheduling data failed schema validation -> HTTP 400
logging.error(f"Invalid scheduling data: {str(e)}")
raise HTTPException(status_code=400, detail=f"Invalid scheduling data: {str(e)}")
except ValueError as e:
# User-supplied scheduling data violated a domain-level validation
# (e.g. positive weight on a squared-deviation shift count objective).
# Surface as HTTP 400 rather than letting it fall through to the
# generic Exception handler (which would log error and return 500).
logging.warning(f"Invalid scheduling input: {str(e)}")
raise HTTPException(status_code=400, detail=f"Invalid scheduling input: {str(e)}")
except Exception as e:
# TODO(security): Returning the error message to the client may be a security risk
logging.error(f"Error during optimization: {str(e)}")
Expand Down
Loading