Skip to content

fix(core): Return HTTP 400 for YAML parsing errors #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(core): Return HTTP 400 for YAML parsing errors #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/nurse_scheduling/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from fastapi.responses import StreamingResponse
from fastapi.middleware.cors import CORSMiddleware
from pydantic import ValidationError
from ruamel.yaml import YAMLError
from . import scheduler, exporter


Expand Down Expand Up @@ -177,6 +178,10 @@ async def optimize_and_export_xlsx(
# User-supplied scheduling data failed schema validation -> HTTP 400
logging.error(f"Invalid scheduling data: {str(e)}")
raise HTTPException(status_code=400, detail=f"Invalid scheduling data: {str(e)}")
except YAMLError as e:
# User-supplied YAML failed to parse -> HTTP 400 (not an internal server error)
logging.warning(f"Invalid YAML: {str(e)}")
raise HTTPException(status_code=400, detail=f"Invalid YAML: {str(e)}")
except Exception as e:
# TODO(security): Returning the error message to the client may be a security risk
logging.error(f"Error during optimization: {str(e)}")
Expand Down
Loading