Skip to content

fix(web-frontend): Handle non-string values in InlineEdit.trim() #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(web-frontend): Handle non-string values in InlineEdit.trim() #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions web-frontend/src/components/InlineEdit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import { useEffect, useRef } from 'react';

interface InlineEditProps {
value: string;
value: string | number | null | undefined;
isEditing: boolean;
onSave: (value: string) => void;
onCancel: () => void;
Expand All @@ -30,7 +30,7 @@ interface InlineEditProps {
className?: string;
editClassName?: string;
error?: string;
displayValue?: string; // For cases where display differs from edit value
displayValue?: string | number | null; // For cases where display differs from edit value
emptyText?: string; // Text to show when value is empty
emptyClassName?: string;
}
Expand Down Expand Up @@ -59,7 +59,7 @@ export function InlineEdit({
}, [isEditing]);

const handleSave = () => {
onSave((inputRef.current?.value ?? value).trim());
onSave(String(inputRef.current?.value ?? value ?? '').trim());
};

const handleKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
Expand All @@ -75,10 +75,10 @@ export function InlineEdit({
if (isEditing) {
return (
<input
key={value}
key={String(value ?? '')}
ref={inputRef}
type="text"
defaultValue={value}
defaultValue={String(value ?? '')}
onKeyDown={handleKeyDown}
onBlur={handleSave}
placeholder={placeholder}
Expand All @@ -87,7 +87,7 @@ export function InlineEdit({
);
}

const valueToDisplay = displayValue || value;
const valueToDisplay = String(displayValue ?? value ?? '');
const hasValue = valueToDisplay.trim().length > 0;
const isReadOnly = !onDoubleClick;

Expand Down
Loading