Add augmented assignment proposal #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for writing it up! In order for this proposal to have a chance, in my opinion we have to address existing and past committee criticisms. You should reference previous proposals, I think there were some. And then we need to go into the J3 mailinglist (I added a link in one of the comments in #113), and address every objection. Otherwise the same objections will be given and the proposal rejected. |
ivan-pi
reviewed
Nov 11, 2021
| often `get_index` is called would depend on the compiler. | ||
|
|
||
| The dot is added between the operator and `=`, since `/=` is already in | ||
| use. |
There was a problem hiding this comment.
Here it would be good to add "in use as the not equal relational operator".
|
Thanks! Do you want me to merge it and do you want to submit it for the next committee meet? |
|
@certik Yes, that'd be great =) Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proposal for augmented assignment with
+.=,/.=etc. following the discussion in #113