Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate new build tag format in Go 1.17 #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qnighy
Copy link

@qnighy qnighy commented Jan 6, 2023

Go 1.17 introduced a new format for build tags, namely //go:build. This PR incorporates the change so that the build tag is written in both formats. This is how go fmt updates the existing code.

Go versions 1.16 and earlier used a different syntax for build constraints, with a "// +build" prefix. The gofmt command will add an equivalent //go:build constraint when encountering the older syntax.

https://pkg.go.dev/cmd/go#hdr-Build_constraints

@qnighy
Copy link
Author

qnighy commented Nov 6, 2023

@izumin5210 could you look at this?

@qnighy
Copy link
Author

qnighy commented Nov 11, 2023

@izumin5210 We have been extensively using izumin5210/gex and izumin5210/grapi and want to have these packages up-to-date with the current state of the ecosystem. You know we have currently submitted three: this PR, #71, and #72.

We are willing to continue contributing the patches if needed, but we cannot merge them ourselves. We need your help.

I understand you are busy and probably aren't as interested in it as before anymore. If you cannot afford time or other resources to review them, we are prepared to propose these alternatives:

  • to inherit the modules' ownerships and help maintain them, if you are willing to give us ones
  • or to fork them ourselves.

I'd appreciate it if I could hear your thoughts on it. Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant