Merged
Conversation
wroyca
requested changes
Dec 10, 2024
wroyca
approved these changes
Dec 11, 2024
Rackover
approved these changes
Dec 20, 2024
Rackover
reviewed
Dec 20, 2024
|
|
||
| struct spawner_ent_t | ||
| { | ||
| int team; |
Contributor
There was a problem hiding this comment.
team_t here too I suppose?
Contributor
Author
There was a problem hiding this comment.
I checked IW4, IW5 and T5 and none of them have this field as a team_t enum, but I still think it's quite likely to be a team_t.
Member
There was a problem hiding this comment.
Can confirm, spawner_ent_t doesn't use team_t on T5; perhaps it's best to leave it as is (int) for now and see how the code references it.
Contributor
There was a problem hiding this comment.
OK; feel free to open another PR if this turns out to be team_t. Even if that's not exactly what's in the symbols, if that's what the game does internally that it makes sense to have it be a team_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This improves the layout of the gentity_s struct.
How does this PR change IW4x's behaviour?
None of the existing code should be affected. I cannot find any references to gentity fields below gentity_s::count, so there shouldn't be any offset problems.
Anything else we should know?
This is based on iw4 xbox360 debug information. Some of the type and field names are my own as I couldn't find their actual names. The struct change should be helpful for the antilag pr: #169 (review)
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)