Skip to content

Conversation

@mbtaylor
Copy link
Member

Changes mostly from running make new-release, but did some manual adjustment of the \previousversion URLs.

Changes mostly from running make new-release, but did some manual
adjustment of the \previousversion URLs.
Copy link
Collaborator

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless enough. (you're aware of ivoatex's make new-release?)

msdemlei

This comment was marked as duplicate.

@mbtaylor
Copy link
Member Author

mbtaylor commented Feb 2, 2026

Thanks @msdemlei but it looks like I still can't merge this since neither you nor I have write access. I think either @andamian or @bsipocz has to approve?

If I'm acting as editor does it make sense for me to acquire Maintainer status? I'm not sure what's normal procedure.

@msdemlei
Copy link
Collaborator

msdemlei commented Feb 2, 2026 via email

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fine start.

@mbtaylor mbtaylor merged commit c9bf520 into ivoa-std:master Feb 2, 2026
1 check passed
@mbtaylor mbtaylor deleted the bump-version-to-1.6 branch February 2, 2026 14:00
@tomdonaldson
Copy link
Contributor

I don't think we have consistent access policies across the repos and it is important to limit access. That said, when I was editor, I had maintainer access so I've gone ahead and added @mbtaylor as maintainer. I also added @msdemlei with write permissions to allow timely reliable reviews. I'm happy to back off these positions as needed pending further discussions with @andamian, @bsipocz and @molinaro-m.

@bsipocz
Copy link
Member

bsipocz commented Feb 2, 2026

I think it's right to have the editors write access. Long term, maybe those access rights should be done via appropriate github teams rather than directly going to individuals, but that's an extreme level of nitpicking and way beyond the scope of the individual repo.

Thanks @msdemlei but it looks like I still can't merge this since neither you nor I have write access.

However, I very much wonder how @mbtaylor didn't have write access as being an org owner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants