Dal review #102
Merged
Dal review #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmantele
suggested changes
Jan 22, 2026
gmantele
left a comment
gmantele
left a comment
There was a problem hiding this comment.
Appart from the two typos and the confusion about ADQL still being in the diagram, I am fine with this.
doc/model.tex
Outdated
| \subsection{Property} | ||
| \label{sect:Property} | ||
| Class holder for a \textit{flavor} of property’ ie: there should be a Property subclass for each \textit{flavor} of Property being hosted. The property types are not limited to “physical or calculated” (eg: flags, assigned labels) This class specifies both type and role of the property, and hosts the property instance itself. | ||
| Class holder for a \textit{flavor} of propert, i.e., there should be a Property subclass for each \textit{flavor} of Property being hosted. The property types are not limited to “physical or calculated” (eg: flags, assigned labels) This class specifies both type and role of the property, and hosts the property instance itself. |
There was a problem hiding this comment.
The final letter of property is missing. Instead of propert it should be property.
doc/model_toc.tex
Outdated
| \subsection{Property} | ||
| \label{sect:Property} | ||
| Class holder for a \textit{flavor} of property’ ie: there should be a Property subclass for each \textit{flavor} of Property being hosted. The property types are not limited to “physical or calculated” (eg: flags, assigned labels) This class specifies both type and role of the property, and hosts the property instance itself. | ||
| Class holder for a \textit{flavor} of propert, i.e., there should be a Property subclass for each \textit{flavor} of Property being hosted. The property types are not limited to “physical or calculated” (eg: flags, assigned labels) This class specifies both type and role of the property, and hosts the property instance itself. |
There was a problem hiding this comment.
Same comment. I assume that it should property.
There was a problem hiding this comment.
ADQL record is still in there. According to your comment in the Mango-1.0-RFC twiki page, it should not be.
gmantele
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAL review correction