Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Caesar cipher.py #5

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Create Caesar cipher.py #5

merged 3 commits into from
Oct 8, 2021

Conversation

IshaSah
Copy link
Contributor

@IshaSah IshaSah commented Oct 5, 2021

A secret message needs to be sent. Here we encrypt the message using Caesar cipher.

Copy link
Owner

@its-Kumar its-Kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

It will be better if you add some documentation or some comments to the code, so that it will be easier to others to understand the code.

@its-Kumar
Copy link
Owner

@IshaSah

@IshaSah
Copy link
Contributor Author

IshaSah commented Oct 8, 2021

yes sir I will do it. Will I need to raise a new pull request after making the changes?

@IshaSah
Copy link
Contributor Author

IshaSah commented Oct 8, 2021

Made the changes requested. can you please review.

@its-Kumar
Copy link
Owner

yes sir I will do it. Will I need to raise a new pull request after making the changes?

Don't call me sir, please

@its-Kumar
Copy link
Owner

No more pull request is needed this is fine now

@its-Kumar its-Kumar merged commit cef5c7d into its-Kumar:main Oct 8, 2021
@IshaSah
Copy link
Contributor Author

IshaSah commented Oct 8, 2021 via email

@its-Kumar its-Kumar linked an issue Oct 30, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contribute to any of the python projects - Hacktoberfest
2 participants