Fix bug: dont remove parent just because children is empty #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
Currently there is a bug with
PdfOutline.removeOutline
function. Here is what happens in this bug:If there is an outline like this:
and, we remove
Child Outline
, then the parent outline automatically gets removed because the parent now has no children.This is the relevant part of the code:
Hence, in this PR, I removed the line
parent.removeOutline();
so that the parent does not get removed.