Skip to content

Conversation

deveshdama
Copy link

Retain existing valid certificates when new fetch attempts fail, improving service reliability during CA outages. Implements backoff scheduling that respects certificate expiry times.
This PR addresses istio issue#56452

@deveshdama deveshdama requested a review from a team as a code owner June 4, 2025 05:22
@istio-policy-bot
Copy link

😊 Welcome @deveshdama! This is either your first contribution to the Istio ztunnel repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Jun 4, 2025
@istio-testing
Copy link
Contributor

Hi @deveshdama. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@keithmattix
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 4, 2025
- fetches now records failed attempts as well.
- validate that valid certificate are retained across fetch attempts despite ca failures
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2025
@deveshdama deveshdama requested a review from howardjohn June 9, 2025 17:10
@deveshdama
Copy link
Author

@howardjohn can you please take a look.

@jaellio
Copy link
Contributor

jaellio commented Jun 23, 2025

@keithmattix or @Stevenjin8 could you PTAL?

@Sridharpage
Copy link

I haven’t seen any updates on this PR for over a month and a half. Could someone please take a look and help move it forward?

@Stevenjin8
Copy link
Contributor

@deveshdama

@deveshdama
Copy link
Author

Sorry for the delay.
@jaellio @Stevenjin8 PTAL.

@Stevenjin8
Copy link
Contributor

@deveshdama lgtm, but need a maintainer to review

@deveshdama
Copy link
Author

@keithmattix can you please help out with review?

@keithmattix
Copy link
Contributor

I'm not an approved; tagging @istio/wg-networking-maintainers-ztunnel for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants