-
Notifications
You must be signed in to change notification settings - Fork 134
retain valid certs on fetch failures #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome @deveshdama! This is either your first contribution to the Istio ztunnel repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @deveshdama. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
- fetches now records failed attempts as well. - validate that valid certificate are retained across fetch attempts despite ca failures
@howardjohn can you please take a look. |
@keithmattix or @Stevenjin8 could you PTAL? |
I haven’t seen any updates on this PR for over a month and a half. Could someone please take a look and help move it forward? |
Sorry for the delay. |
@deveshdama lgtm, but need a maintainer to review |
@keithmattix can you please help out with review? |
I'm not an approved; tagging @istio/wg-networking-maintainers-ztunnel for review |
Retain existing valid certificates when new fetch attempts fail, improving service reliability during CA outages. Implements backoff scheduling that respects certificate expiry times.
This PR addresses istio issue#56452