Skip to content

slices: remove redundant zeroing in Delete #50760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Apr 30, 2024
Merged

slices: remove redundant zeroing in Delete #50760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkg/slices/slices.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,8 @@ func Clone[S ~[]E, E any](s S) S {

// Delete removes the element i from s, returning the modified slice.
func Delete[S ~[]E, E any](s S, i int) S {
// "If those elements contain pointers you might consider zeroing those elements
// so that objects they reference can be garbage collected."
var empty E
s[i] = empty
// Since Go 1.22, "slices.Delete zeroes the elements s[len(s)-(j-i):len(s)]"
// (no memory leak)
return slices.Delete(s, i, i+1)
}

Expand Down