-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix: Site BaseURLs #16568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: Site BaseURLs #16568
Conversation
Hi @Ajay-singh1. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can you ping me on the Istio Slack please Ajay? |
/ok-to-test (I think you can join as a member now btw) |
0212a07
to
2c735ca
Compare
de2a06d
to
b7ca906
Compare
@craigbox I have got a working solution now.We can check the sitemap for preliminary deployment and it is generating those sitemaps correctly.See :- Sitemap for Preliminary deployment. |
We have to cherry-pick release to see it in production. |
we could do that, assuming we have a roll back plan. One thing I was wondering is if we should set up a custom page which just shows the variables, push that through all the sites first, and verify the values are as expected? |
I’ve reviewed the changes and I’m confident they won’t break anything. We have a rollback plan — we can revert the commit or use Netlify’s rollback option. I think we’re safe to proceed without the custom debug page. |
This isn't working as expected. Look at https://deploy-preview-16568--preliminary-istio.netlify.app/ for example - all the links are now to preliminary.istio.io. |
Description
Related Issue:-#16559
This PR fixes incorrect baseURL values used during site generation, which were causing invalid or broken URLs in sitemap.xml.
Testing:-
1.Locally tested this with the command
CONTEXT=production make netlify
this generates the correct sitemaps.Reviewers