Skip to content

Fix: Site BaseURLs #16568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Site BaseURLs #16568

wants to merge 2 commits into from

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented Jun 9, 2025

Description

Related Issue:-#16559

This PR fixes incorrect baseURL values used during site generation, which were causing invalid or broken URLs in sitemap.xml.

Testing:-

1.Locally tested this with the command CONTEXT=production make netlify this generates the correct sitemaps.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner June 9, 2025 09:26
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Jun 9, 2025
@istio-testing
Copy link
Contributor

Hi @Ajay-singh1. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@craigbox
Copy link
Contributor

craigbox commented Jun 9, 2025

Can you ping me on the Istio Slack please Ajay?

@craigbox
Copy link
Contributor

craigbox commented Jun 9, 2025

/ok-to-test

(I think you can join as a member now btw)

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 9, 2025
@Ajay-singh1 Ajay-singh1 force-pushed the fix-baseURL branch 2 times, most recently from 0212a07 to 2c735ca Compare June 9, 2025 11:14
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2025
@Ajay-singh1 Ajay-singh1 force-pushed the fix-baseURL branch 2 times, most recently from de2a06d to b7ca906 Compare June 9, 2025 13:22
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2025
@Ajay-singh1 Ajay-singh1 changed the title Test:Fix BaseURLs Fix: SIte BaseURLs Jun 9, 2025
@Ajay-singh1 Ajay-singh1 changed the title Fix: SIte BaseURLs Fix: Site BaseURLs Jun 9, 2025
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2025
@Ajay-singh1
Copy link
Contributor Author

@craigbox I have got a working solution now.We can check the sitemap for preliminary deployment and it is generating those sitemaps correctly.See :- Sitemap for Preliminary deployment.

@Ajay-singh1 Ajay-singh1 requested a review from craigbox June 11, 2025 08:34
@Ajay-singh1
Copy link
Contributor Author

We have to cherry-pick release to see it in production.

@craigbox
Copy link
Contributor

we could do that, assuming we have a roll back plan.

One thing I was wondering is if we should set up a custom page which just shows the variables, push that through all the sites first, and verify the values are as expected?

@Ajay-singh1
Copy link
Contributor Author

I’ve reviewed the changes and I’m confident they won’t break anything. We have a rollback plan — we can revert the commit or use Netlify’s rollback option. I think we’re safe to proceed without the custom debug page.

@craigbox
Copy link
Contributor

This isn't working as expected.

Look at https://deploy-preview-16568--preliminary-istio.netlify.app/ for example - all the links are now to preliminary.istio.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants