-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add Out-Of-Date Documentation header for archive versions #16457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is not served on any documentation site.
It will be - that's the point of the exercise. We will regenerate and re-copy the archives to the current site in order to get these changes to apply. |
Gotcha.. sorry.. I didn't know that was the plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last fix requests left inline.
Will the lint ever pass? Don't think so, but it should never be a problem as this header is only added when building in archive mode.
The archive pages are not linted, so I think a mass update to those won't cause a problem.
Alternatively we can detect that we're in archive mode and disable link checking.
@dhawton for thoughts
@craigbox 🇺🇦 Ukrainian translation 👇 [archive_banner_text]
other = "⚠️ Це документація для (застарілої) версії (<strong>%s</strong>), яка вже не підтримується."
[archive_banner_link]
other = "Читати останню версію." |
Chinese version: [archive_banner_text]
other = "⚠️ 此文档针对过时的版本 (<strong>%s</strong>),将不在维护和更新。"
[archive_banner_link]
other = "查看最新文档。" |
@sbegin0: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Added a warning header to all docs pages warning user that this version is out-of-date with an option to go to /latest
Rebasing onto master to merge and cherrypick, and then run against the existing archives. |
In response to a cherrypick label: new pull request created: #16521 |
In response to a cherrypick label: new pull request created: #16527 |
In response to a cherrypick label: new pull request created: #16530 |
In response to a cherrypick label: new issue created for failed cherrypick: #16532 |
In response to a cherrypick label: new issue created for failed cherrypick: #16533 |
Description
Added a warning header to all docs pages warning user that this version is out-of-date with an option to go to /latest
Reviewers