Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Updated outdated docs]. Installation of istio ambient mode in different platforms #15709

Open
wants to merge 1 commit into
base: release-1.23
Choose a base branch
from

Conversation

nullxx
Copy link

@nullxx nullxx commented Sep 19, 2024

Some installation values customizing the cni where outdated

Description

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Some installation values customizing the cni where outdated
Copy link

CLA Not Signed

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Sep 19, 2024
@istio-testing
Copy link
Contributor

Hi @nullxx. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhawton
Copy link
Member

dhawton commented Sep 19, 2024

Like the other PR, recommend opening the PR against master. We can cherrypick to release-1.23, but this is going backward.

@nullxx
Copy link
Author

nullxx commented Sep 19, 2024

Like the other PR, recommend opening the PR against master. We can cherrypick to release-1.23, but this is going backward.

@dhawton In the master branch, there is a different way of specifying the platform of installation. You must define different variables.

Since it's generally better to work with the latest changes, this correction applies specifically to this version of the documentation. It's important to ensure that the documentation is accurate and functional for each version.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ambient area/environments kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants