Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #15700

Open
wants to merge 1 commit into
base: release-1.23
Choose a base branch
from
Open

Update index.md #15700

wants to merge 1 commit into from

Conversation

AleksFirsta
Copy link

all cofnig align of lest and when you copy/paste you need to update it manually

Description

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

all cofnig align of lest and when you copy/paste you need to update it manually
@AleksFirsta AleksFirsta requested a review from a team as a code owner September 17, 2024 13:18
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

Copy link

CLA Not Signed

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Sep 17, 2024
@istio-testing
Copy link
Contributor

Hi @AleksFirsta. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kfaseela
Copy link
Member

Hello @AleksFirsta , are you trying to fix #15689 ? If so, your change will break the test.

@AleksFirsta
Copy link
Author

AleksFirsta commented Sep 17, 2024

Hello @AleksFirsta , are you trying to fix #15689 ? If so, your change will break the test.

Hi @kfaseela yes it is. I noticed that text bash in table affected. that why tried to show it like yaml

@dhawton
Copy link
Member

dhawton commented Sep 17, 2024

Hello @AleksFirsta , are you trying to fix #15689 ? If so, your change will break the test.

Hi @kfaseela yes it is. I noticed that text bash in table affected. that why tried to show it like yaml

Which breaks testing, since the test will run that command.. or should.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 18, 2024
@istio-testing
Copy link
Contributor

@AleksFirsta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_istio.io_release-1.23 c607726 link true /test gencheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zirain
Copy link
Member

zirain commented Sep 19, 2024

I think the problem related to the implement of tabset. Things look good with following patch:

diff --git a/content/en/docs/tasks/traffic-management/mirroring/index.md b/content/en/docs/tasks/traffic-management/mirroring/index.md
index 69385cc53..99289394c 100644
--- a/content/en/docs/tasks/traffic-management/mirroring/index.md
+++ b/content/en/docs/tasks/traffic-management/mirroring/index.md
@@ -136,11 +136,7 @@ By default Kubernetes load balances across both versions of the `httpbin` servic
 In this step, you will change that behavior so that all traffic goes to `v1`.
 
 1. Create a default route rule to route all traffic to `v1` of the service:
-
-    {{< tabset category-name="config-api" >}}
-
-    {{< tab name="Istio APIs" category-value="istio-apis" >}}
-
+    
     {{< text bash >}}
     $ kubectl apply -f - <<EOF
     apiVersion: networking.istio.io/v1
@@ -173,10 +169,6 @@ In this step, you will change that behavior so that all traffic goes to `v1`.
     EOF
     {{< /text >}}
 
-    {{< /tab >}}
-
-    {{< tab name="Gateway API" category-value="gateway-api" >}}
-
     {{< text bash >}}
     $ kubectl apply -f - <<EOF
     apiVersion: v1
@@ -220,10 +212,6 @@ In this step, you will change that behavior so that all traffic goes to `v1`.
     EOF
     {{< /text >}}
 
-    {{< /tab >}}
-
-    {{< /tabset >}}
-
 1. Now, with all traffic directed to `httpbin:v1`, send a request to the service:
 
     {{< text bash json >}}
@@ -244,7 +232,7 @@ In this step, you will change that behavior so that all traffic goes to `v1`.
     }
     {{< /text >}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants