-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md #15700
base: release-1.23
Are you sure you want to change the base?
Update index.md #15700
Conversation
all cofnig align of lest and when you copy/paste you need to update it manually
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @AleksFirsta. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hello @AleksFirsta , are you trying to fix #15689 ? If so, your change will break the test. |
Hi @kfaseela yes it is. I noticed that text bash in table affected. that why tried to show it like yaml |
Which breaks testing, since the test will run that command.. or should. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@AleksFirsta: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I think the problem related to the implement of
|
all cofnig align of lest and when you copy/paste you need to update it manually
Description
Reviewers