Skip to content

Add helm installation steps for multi-cluster #15459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nshankar13
Copy link
Contributor

@nshankar13 nshankar13 commented Jul 22, 2024

Description

Adds Helm multi-cluster installation steps for all Istio multi-cluster control plane models and network topologies.

Preview link for quick reference: https://deploy-preview-15459--preliminary-istio.netlify.app/latest/docs/setup/install/multicluster/multi-primary/

Resolves: #14765

Tested against Istio 1.24.0 Helm charts.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@nshankar13 nshankar13 changed the title Add helm installation steps for multi-primary Add helm installation steps for multi-cluster Jul 22, 2024
@nshankar13 nshankar13 marked this pull request as draft July 22, 2024 16:10
@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@nshankar13 nshankar13 marked this pull request as ready for review July 30, 2024 16:13
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 30, 2024
@dhawton
Copy link
Member

dhawton commented Jul 30, 2024

Since you're updating snips here, make sure they get added to the testing.

@nshankar13
Copy link
Contributor Author

nshankar13 commented Jul 31, 2024

@dhawton any ideas on why the lint check is complaining about spelling here?

"Install Istio as primary in cluster1 using istioctl and the IstioOperator api"

@dhawton
Copy link
Member

dhawton commented Aug 1, 2024

@dhawton any ideas on why the lint check is complaining about spelling here?

"Install Istio as primary in cluster1 using istioctl and the IstioOperator api"

Running locally (make lint) is easier to identify. It's because it's API not api.

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2024
@nshankar13 nshankar13 requested a review from a team as a code owner August 7, 2024 20:02
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 7, 2024
@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 2e35870 to a95cc56 Compare August 7, 2024 20:05
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 7, 2024
@nshankar13
Copy link
Contributor Author

/test doc.test.profile-default

@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 61e5b13 to f1e6b4d Compare August 9, 2024 23:24
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 14, 2024
@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from 819b0fc to d5bf3c0 Compare August 14, 2024 21:13
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 14, 2024
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
Signed-off-by: nshankar <[email protected]>
@nshankar13 nshankar13 force-pushed the nshankar/helm-multicluster-install-steps branch from b778f81 to 56d1433 Compare November 22, 2024 20:53
@craigbox craigbox removed the request for review from dhawton November 23, 2024 02:32
@istio-testing istio-testing merged commit baf2a3d into istio:master Nov 23, 2024
13 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: #15459 failed to apply on top of branch "release-1.24":

Applying: Add helm installation steps for multi-primary
Applying: Update clusterid
Applying: Update config steps
Applying: Edit steps
Applying: Update multi-primary steps
Applying: Update files and docs
Applying: Add primary-remote steps
Applying: Edit spacing
Applying: Remove var
Applying: Fix cluster name
Applying: Update snips
Applying: Update docs
Applying: Update commands
Applying: Update docs
Applying: Update note
Applying: Resolve comments and UTs
Applying: Add quotes
Applying: Run make gen
Applying: Add more quotes
Applying: Fix lints
Applying: fix lint and spelling
Applying: Update tests
Applying: Add new tests for helm
Applying: Fix test
Applying: Update go.mod
Applying: Update installation scripts
Applying: Update helm repo setup scripts
Applying: Update cleanup steps
Applying: Update script and lint
Applying: update cleanup step
Applying: Update cleanup steps
Applying: Update cleanup steps
Applying: Fix cleanup script
Applying: Fix installation steps
Applying: Update scripts
Applying: Update istio-system ns creation steps
Applying: Fix CRD cleanup
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
Applying: Update Helm CRD Cleanup
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
Applying: Update cleanup
Applying: Remove additional var
Applying: Resolve comments
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
Applying: fix go.mod
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
Applying: Fix lint
Applying: update charts for remote profile
Applying: Update indentation
Applying: Update indentation
Applying: Fix lint
Applying: Fix numbering
Applying: Update installation steps
Applying: Add missing steps
Applying: Update cleanup steps
Applying: Fix indentation
Applying: Update indentation
Applying: Resolve comments
Applying: Resolve comments
Applying: update go.mod
Applying: remove cleanup
Applying: Update CRD cleanup
Applying: Update cleanup
Applying: Update cleanup
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0060 Update cleanup

@istio-testing
Copy link
Contributor

In response to a cherrypick label: new issue created for failed cherrypick: #15982

nshankar13 added a commit to nshankar13/istio.io that referenced this pull request Nov 26, 2024
* Add helm installation steps for multi-primary

Signed-off-by: nshankar <[email protected]>

* Update clusterid

Signed-off-by: nshankar <[email protected]>

* Update config steps

Signed-off-by: nshankar <[email protected]>

* Edit steps

Signed-off-by: nshankar <[email protected]>

* Update multi-primary steps

Signed-off-by: nshankar <[email protected]>

* Update files and docs

Signed-off-by: nshankar <[email protected]>

* Add primary-remote steps

Signed-off-by: nshankar <[email protected]>

* Edit spacing

Signed-off-by: nshankar <[email protected]>

* Remove var

Signed-off-by: nshankar <[email protected]>

* Fix cluster name

Signed-off-by: nshankar <[email protected]>

* Update snips

Signed-off-by: nshankar <[email protected]>

* Update docs

Signed-off-by: nshankar <[email protected]>

* Update commands

Signed-off-by: nshankar <[email protected]>

* Update docs

Signed-off-by: nshankar <[email protected]>

* Update note

Signed-off-by: nshankar <[email protected]>

* Resolve comments and UTs

Signed-off-by: nshankar <[email protected]>

* Add quotes

Signed-off-by: nshankar <[email protected]>

* Run make gen

Signed-off-by: nshankar <[email protected]>

* Add more quotes

Signed-off-by: nshankar <[email protected]>

* Fix lints

Signed-off-by: nshankar <[email protected]>

* fix lint and spelling

Signed-off-by: nshankar <[email protected]>

* Update tests

Signed-off-by: nshankar <[email protected]>

* Add new tests for helm

Signed-off-by: nshankar <[email protected]>

* Fix test

Signed-off-by: nshankar <[email protected]>

* Update go.mod

Signed-off-by: nshankar <[email protected]>

* Update installation scripts

Signed-off-by: nshankar <[email protected]>

* Update helm repo setup scripts

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Update script and lint

Signed-off-by: nshankar <[email protected]>

* update cleanup step

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Fix cleanup script

Signed-off-by: nshankar <[email protected]>

* Fix installation steps

Signed-off-by: nshankar <[email protected]>

* Update scripts

Signed-off-by: nshankar <[email protected]>

* Update istio-system ns creation steps

Signed-off-by: nshankar <[email protected]>

* Fix CRD cleanup

Signed-off-by: nshankar <[email protected]>

* Update Helm CRD Cleanup

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Remove additional var

Signed-off-by: nshankar <[email protected]>

* Resolve comments

Signed-off-by: nshankar <[email protected]>

* fix go.mod

Signed-off-by: nshankar <[email protected]>

* Fix lint

Signed-off-by: nshankar <[email protected]>

* update charts for remote profile

Signed-off-by: nshankar <[email protected]>

* Update indentation

Signed-off-by: nshankar <[email protected]>

* Update indentation

Signed-off-by: nshankar <[email protected]>

* Fix lint

Signed-off-by: nshankar <[email protected]>

* Fix numbering

Signed-off-by: nshankar <[email protected]>

* Update installation steps

Signed-off-by: nshankar <[email protected]>

* Add missing steps

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Fix indentation

Signed-off-by: nshankar <[email protected]>

* Update indentation

Signed-off-by: nshankar <[email protected]>

* Resolve comments

Signed-off-by: nshankar <[email protected]>

* Resolve comments

Signed-off-by: nshankar <[email protected]>

* update go.mod

Signed-off-by: nshankar <[email protected]>

* remove cleanup

Signed-off-by: nshankar <[email protected]>

* Update CRD cleanup

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Rebase and update cleanup

Signed-off-by: nshankar <[email protected]>

---------

Signed-off-by: nshankar <[email protected]>
istio-testing pushed a commit that referenced this pull request Nov 26, 2024
* Add helm installation steps for multi-cluster (#15459)

* Add helm installation steps for multi-primary

Signed-off-by: nshankar <[email protected]>

* Update clusterid

Signed-off-by: nshankar <[email protected]>

* Update config steps

Signed-off-by: nshankar <[email protected]>

* Edit steps

Signed-off-by: nshankar <[email protected]>

* Update multi-primary steps

Signed-off-by: nshankar <[email protected]>

* Update files and docs

Signed-off-by: nshankar <[email protected]>

* Add primary-remote steps

Signed-off-by: nshankar <[email protected]>

* Edit spacing

Signed-off-by: nshankar <[email protected]>

* Remove var

Signed-off-by: nshankar <[email protected]>

* Fix cluster name

Signed-off-by: nshankar <[email protected]>

* Update snips

Signed-off-by: nshankar <[email protected]>

* Update docs

Signed-off-by: nshankar <[email protected]>

* Update commands

Signed-off-by: nshankar <[email protected]>

* Update docs

Signed-off-by: nshankar <[email protected]>

* Update note

Signed-off-by: nshankar <[email protected]>

* Resolve comments and UTs

Signed-off-by: nshankar <[email protected]>

* Add quotes

Signed-off-by: nshankar <[email protected]>

* Run make gen

Signed-off-by: nshankar <[email protected]>

* Add more quotes

Signed-off-by: nshankar <[email protected]>

* Fix lints

Signed-off-by: nshankar <[email protected]>

* fix lint and spelling

Signed-off-by: nshankar <[email protected]>

* Update tests

Signed-off-by: nshankar <[email protected]>

* Add new tests for helm

Signed-off-by: nshankar <[email protected]>

* Fix test

Signed-off-by: nshankar <[email protected]>

* Update go.mod

Signed-off-by: nshankar <[email protected]>

* Update installation scripts

Signed-off-by: nshankar <[email protected]>

* Update helm repo setup scripts

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Update script and lint

Signed-off-by: nshankar <[email protected]>

* update cleanup step

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Fix cleanup script

Signed-off-by: nshankar <[email protected]>

* Fix installation steps

Signed-off-by: nshankar <[email protected]>

* Update scripts

Signed-off-by: nshankar <[email protected]>

* Update istio-system ns creation steps

Signed-off-by: nshankar <[email protected]>

* Fix CRD cleanup

Signed-off-by: nshankar <[email protected]>

* Update Helm CRD Cleanup

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Remove additional var

Signed-off-by: nshankar <[email protected]>

* Resolve comments

Signed-off-by: nshankar <[email protected]>

* fix go.mod

Signed-off-by: nshankar <[email protected]>

* Fix lint

Signed-off-by: nshankar <[email protected]>

* update charts for remote profile

Signed-off-by: nshankar <[email protected]>

* Update indentation

Signed-off-by: nshankar <[email protected]>

* Update indentation

Signed-off-by: nshankar <[email protected]>

* Fix lint

Signed-off-by: nshankar <[email protected]>

* Fix numbering

Signed-off-by: nshankar <[email protected]>

* Update installation steps

Signed-off-by: nshankar <[email protected]>

* Add missing steps

Signed-off-by: nshankar <[email protected]>

* Update cleanup steps

Signed-off-by: nshankar <[email protected]>

* Fix indentation

Signed-off-by: nshankar <[email protected]>

* Update indentation

Signed-off-by: nshankar <[email protected]>

* Resolve comments

Signed-off-by: nshankar <[email protected]>

* Resolve comments

Signed-off-by: nshankar <[email protected]>

* update go.mod

Signed-off-by: nshankar <[email protected]>

* remove cleanup

Signed-off-by: nshankar <[email protected]>

* Update CRD cleanup

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Rebase and update cleanup

Signed-off-by: nshankar <[email protected]>

---------

Signed-off-by: nshankar <[email protected]>

* add cleanup

Signed-off-by: nshankar <[email protected]>

* delete crds

Signed-off-by: nshankar <[email protected]>

* Delete crds func

Signed-off-by: nshankar <[email protected]>

* update script

Signed-off-by: nshankar <[email protected]>

* Update

Signed-off-by: nshankar <[email protected]>

* Update cleanup

Signed-off-by: nshankar <[email protected]>

* Fix cleanup steps

Signed-off-by: nshankar <[email protected]>

* Update go.mod

Signed-off-by: nshankar <[email protected]>

---------

Signed-off-by: nshankar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch kind/docs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multicluster documentation uses the operator installation model
7 participants