Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few clarifications, add revision #15082

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Conversation

costinm
Copy link
Contributor

@costinm costinm commented May 14, 2024

Description

Few small changes around using revision and clarifications on policies.

Previous PR got messed up.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@costinm costinm requested a review from a team as a code owner May 14, 2024 05:41
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 14, 2024
@dhawton
Copy link
Member

dhawton commented May 14, 2024

/test lint

dhawton and others added 21 commits May 20, 2024 09:41
* bump api and istio refs

* add some debug

* test if we still failure if I disable this one test

* revert debug
* Copy edits

* Update index.md
…me (istio#15083)

* updating dashboard instructions to reflect latest kubernetes dashboard install with helm and the new service name

* adds issuer tip and acme tip for certmanager

* fixes issuer marking

* fix linting issues

* Update content/en/docs/ops/integrations/certmanager/index.md

Co-authored-by: Daniel Hawton <[email protected]>

* Update content/en/docs/ops/integrations/certmanager/index.md

Co-authored-by: Daniel Hawton <[email protected]>

* fix idents

* fix indents

---------

Co-authored-by: Daniel Hawton <[email protected]>
* Translate Ambient L4 policy usage doc into Chinese

* Add missed cni
* added link for quick start in spire

* changed the link for spire quick start
* Translate Ambient add workload doc into Chinese

* Finish translate
* changed #7dc5f2 to #7dc6f8 based on istio#12022

* Added comment on the color change

* multi line comment changed to single line

* updated comment in _panel.scss

* Updated comment in _panel.scss

* added doc about Wasm Configuration for Ambient Mode

* fixed lint errors

* fixed lint errors

* added apply wasmplugin for a service using waypoint and updated

* changed ambient mesh to ambient mode

* changed title and folder name

* changed ambient mesh to ambient mode

* updated _index.md

* updated doc for clarity

* updated doc for clarity

* corrected spelling error

* corrected spelling error

* corrected spelling error

* updated doc for clarity

* updated doc and adjusted location

* updated doc for clarity

* updated doc for clarity

* updated doc for clarity

* updated doc for clarity
…Chinese (istio#15066)

* Sync latest Ambient HBONE and traffic redirection docs into Chinese

* Sync ambient arch home page

* Fix format
* Translate Gateway API Mesh stable blog into Chinese

* Finish translate

* Fix lint
* Translate Ambient beta blog into Chinese

* start translate

* translate

* Finish
* Translate 122 change note

* Translate 1.22 change note into Chinese

* Fix lint: links

* Fix lint
* Fix 404 links in ambient usage and architecture docs

* apply suggestions from kfaseela
* draft translate

* translate

* translate announcing 1.22

* finish translate and waiting for blog merge

* Finish translate

* Apply suggestions from code review

Co-authored-by: Michael <[email protected]>

---------

Co-authored-by: Michael <[email protected]>
istio-testing and others added 17 commits May 20, 2024 09:41
* Add a note about init containers and OpenShift

* Update content/en/docs/setup/additional-setup/cni/index.md

Co-authored-by: Faseela K <[email protected]>

---------

Co-authored-by: Faseela K <[email protected]>
* changed test:yes in wasm for ambient doc

* generated snips.sh

* added test.sh for wasm-ambient doc

* updated test.sh

* added snip_cleanup_1
…upport (istio#15103)

* changed #7dc5f2 to #7dc6f8 based on istio#12022

* Added comment on the color change

* multi line comment changed to single line

* updated comment in _panel.scss

* Updated comment in _panel.scss

* Gateway API support changes

* Gateway API support changes

* Gateway API support changes

* fixed lint error

* changed the link title

* Update content/en/boilerplates/gateway-api-future.md

* Update gateway-api-future.md

---------

Co-authored-by: Faseela K <[email protected]>
Co-authored-by: Craig Box <[email protected]>
…#15145)

* correct the document on this page, issue istio#15144

issue istio#15144 

correct incorrect numbering list and remove redundant content

* modify index.md

ordered list number adjust
@costinm costinm requested review from a team as code owners May 20, 2024 16:42
Copy link

linux-foundation-easycla bot commented May 20, 2024

CLA Missing ID CLA Not Signed

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2024
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2024
@costinm
Copy link
Contributor Author

costinm commented May 20, 2024

/retest

@istio-testing
Copy link
Contributor

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile-demo_istio.io 90dae5e link true /test doc.test.profile-demo
doc.test.profile-none_istio.io 90dae5e link true /test doc.test.profile-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@craigbox
Copy link
Contributor

Looks like this PR got messed up too. Want to try again and I can review early next week?

@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.