Remove legacy Policy type
#3370
Open
+0
−2,287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
zirain
approved these changes
Nov 27, 2024
|
@kyessenov can you verify we don't actually need this for something? |
|
s/1.24/1.6/ - istio/istio#22602 @kyessenov bump! |
|
I thought the same but we actually used it internally in Envoy until 1.24
IIUC
…On Thu, Dec 12, 2024 at 2:49 PM Craig Box ***@***.***> wrote:
s/1.24/1.6/ - istio/istio#22602
<istio/istio#22602>
@kyessenov <https://github.com/kyessenov> bump!
—
Reply to this email directly, view it on GitHub
<#3370 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXLH5JKCQBEBNPWCY732FIHGXAVCNFSM6AAAAABSTPX2LOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBQGE3DINRZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
istio-testing
added
the
needs-rebase
costinm
approved these changes
Jan 4, 2025
hzxuzhonghu
approved these changes
Jan 6, 2025
|
ping @kyessenov if you have a chance to verify we are not using this somewhere I didn't understand? |
kyessenov
approved these changes
Apr 11, 2025
This has not been used for many many years
howardjohn
force-pushed
the
api/remove-deadcode
branch
from
a8e6d0c to
c028ab4
Compare
istio-testing
removed
the
needs-rebase
zirain
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has not been used since Istio 1.24. We should consider cleaning up others like tcp_cluster_rewrite/v2alpha1 and jwt_auth/v2alpha1 as well