fix(webview): open terminal file links in editor - #47
Merged
Conversation
islee23520
force-pushed
the
fix/file-link-open-routing
branch
from
June 1, 2026 11:14
3c9a3ca to
58cdcb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@src/foo.ts:12:3,src/foo.ts,src/foo.ts:12,README.md#L10, andfile:///...pathsopenFilewebview messageULW plan
plans/triaged-issues-ulw-plan.md, Wave 3 (Can I open the file via ctrl + click the file in opencode sessions? #42 file link Ctrl/Cmd-click open)Verification
npm run test -- src/webview/links/index.test.ts src/providers/MessageRouter.test.ts src/types.test.tsfailed before implementation for at-prefixed path suffix parsing, file URI suffix parsing, and invalid openFile location guardsnpm run test -- src/webview/links/index.test.ts src/providers/MessageRouter.test.ts src/types.test.ts(74 tests)npm run compilenpm run lint -- src/webview/links/index.ts src/webview/links/index.test.ts src/providers/openFile.ts src/providers/MessageRouter.ts src/providers/MessageRouter.test.ts src/types.ts src/types.test.tsnpm run compile:e2egit diff --check origin/main...HEADQA_DONE:0)Note
MessageRouter.tsis still larger than ideal, but this change extracts open-file behavior tosrc/providers/openFile.tsinstead of adding more logic to the router.