Skip to content

Conversation

benjaminum
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Fix failing test OrientedBoundingBox/OrientedBoundingBoxPermuteDevices.CreateFromPoints

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This patch copies the returned OBB to the same device as the inputs to align with the behavior of the PCA method.

Copy link

update-docs bot commented Apr 1, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum benjaminum requested a review from ssheorey April 2, 2025 15:02
@ssheorey ssheorey merged commit 1d72c8a into main Apr 2, 2025
33 of 45 checks passed
@ssheorey ssheorey deleted the bu/fix_obb_cuda branch April 2, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants