-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fixes for using system packages #7177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christian-rauch for these fixes! Please see one comment below.
Btw, |
The CI is showing errors seemingly unrelated to this PR, such as
and the main branch also does not pass the CI. |
@ssheorey Can you have a look at this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christian-rauch looks good.
I'll update with main
to check if we can pass CI.
@ssheorey I remove the "WITH_MINIZIP" commit to see if this reduces test failures. I am still getting test failures without this commit, but those are the same as on the |
These CI failures are OK - they are unrelated (some are github issues - out of disk space on runners). |
No, let's merge this first. I am quite sure that the MINIZIP commit caused some additional test failures. I will send a separate PR for this to better disentangle the test failure causes. |
I was building Open3D with most system packages enabled and some features deactivated. This uncovered a couple of compilation and linking issues, such as:
usingExtractZIP
whenWITH_MINIZIP
is offUSE_SYSTEM_CURL
andUSE_SYSTEM_OPENSSL
are setType
Motivation and Context
Fixing the build
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description