Skip to content

Commit 9808b6b

Browse files
authored
Fixes the way seed was set in the benchmark_non_rl script (#3741)
# Description When seed was added to the benchmark_non_rl.py script, it was mistakenly trying to read from simulation config, which doesn't exist. We can set seed directly from the cli arguments since it's ok to be None if it's not specified. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 6f013fb commit 9808b6b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/benchmarks/benchmark_non_rl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def main(env_cfg: ManagerBasedRLEnvCfg | DirectRLEnvCfg | DirectMARLEnvCfg, agen
113113
# override configurations with non-hydra CLI arguments
114114
env_cfg.scene.num_envs = args_cli.num_envs if args_cli.num_envs is not None else env_cfg.scene.num_envs
115115
env_cfg.sim.device = args_cli.device if args_cli.device is not None else env_cfg.sim.device
116-
env_cfg.seed = args_cli.seed if args_cli.seed is not None else env_cfg.sim.seed
116+
env_cfg.seed = args_cli.seed
117117

118118
# process distributed
119119
world_size = 1

0 commit comments

Comments
 (0)