[#223] Use MySQL ODBC connector 8.0.33 for MariaDB projects #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trel
reviewed
Jul 17, 2024
alanking
approved these changes
Jul 18, 2024
Since iRODS works just fine with MariaDB when the MySQL ODBC driver is used, let's switch over. I've left a boolean at the top of `odbc_setup.py` that can be used to switch back to the MariaDB ODBC driver, to allow for easier testing when working on irods/irods#7323. Once irods/irods#7323 is fixed, this commit should be reverted, unless it has already been superseded by irods#208.
|
#'d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #223
I've left a boolean at the top of
odbc_setup.pythat can be used to switch back to the MariaDB ODBC driver, to allow for easier testing when working on irods/irods#7323.Once irods/irods#7323 is fixed, this PR should be reverted, unless it has already been superseded by #208.