Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mysql/mariadb mix-and-match odbc projects #208

Open
SwooshyCueb opened this issue May 15, 2024 · 3 comments
Open

Add mysql/mariadb mix-and-match odbc projects #208

SwooshyCueb opened this issue May 15, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@SwooshyCueb
Copy link
Member

SwooshyCueb commented May 15, 2024 •
edited
Loading

Prerequisite: #167

Presently, iRODS works just fine with MariaDB, provided a MySQL ODBC driver is used. (I think. I've tested basic commands, but I haven't run the full test suite.)
Let's add projects for testing iRODS with mis-matched MySQL/MariaDB ODBC drivers.
@alanking alanking added the enhancement New feature or request label May 15, 2024
@alanking
Copy link
Contributor

One effort which could make this slightly easier to do would be #58, which is basically a stand-in issue for re-doing the way we set up the ODBC drivers for each platform. Right now, I would say that it is less than ideal to have to add a function for each project.

That being said, it's not a prerequisite. Just mentioning it in case it could help to know that.

@SwooshyCueb
Copy link
Member Author

I would say that it is less than ideal to have to add a function for each project.

I agree completely. The less project-specific stuff we have outside the projects folder, the better.

@alanking alanking mentioned this issue Jul 17, 2024
Closed
@korydraughn
Copy link
Contributor

As noted in the linked issue, #223, I've confirmed that all unit/core tests pass when using the MySQL 8 ODBC drivers with MariaDB.

@SwooshyCueb SwooshyCueb mentioned this issue Jul 17, 2024
Merged
SwooshyCueb added a commit to SwooshyCueb/irods_testing_environment that referenced this issue Jul 18, 2024
@SwooshyCueb
[irods#223] Use MySQL ODBC connector 8.0.33 for MariaDB projects
54e2b89 
Since iRODS works just fine with MariaDB when the MySQL ODBC driver is used,
let's switch over.

I've left a boolean at the top of `odbc_setup.py` that can be used to switch
back to the MariaDB ODBC driver, to allow for easier testing when working on
irods/irods#7323.

Once irods/irods#7323 is fixed, this commit should be reverted, unless it has
already been superseded by irods#208.
alanking pushed a commit that referenced this issue Jul 18, 2024
@SwooshyCueb @alanking
[#223] Use MySQL ODBC connector 8.0.33 for MariaDB projects
13cb1a9 
Since iRODS works just fine with MariaDB when the MySQL ODBC driver is used,
let's switch over.

I've left a boolean at the top of `odbc_setup.py` that can be used to switch
back to the MariaDB ODBC driver, to allow for easier testing when working on
irods/irods#7323.

Once irods/irods#7323 is fixed, this commit should be reverted, unless it has
already been superseded by #208.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SwooshyCueb @korydraughn @alanking