[#57] Add more details to README.md #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a note about Docker Image tags in the instructions for building the builders - Add more details about directory structures and naming schemes as it relates to the build and test hooks for iRODS plugins as these use a specific system for package discovery and installation
alanking
commented
Jun 3, 2022
| ``` | ||
| NOTE: `/path/to/built_irods_packages` should point to the directory containing the different directories for packages of the various platforms AND the symlinks to said directories, if you have been following the pattern described above. | ||
|
|
||
| Another thing to keep in mind: the test hook for iRODS plugins also uses the same directory naming scheme when attempting to discover built plugin packages for testing. You may wish to consider using a directory structure similar to the built iRODS packages as described above for the output directory of your built plugin packages so that the built and test hooks can work in tandem. |
There was a problem hiding this comment.
built and test hooks -> build and test hooks
| ``` | ||
| NOTE: `/path/to/built_irods_packages` should point to the directory containing the different directories for packages of the various platforms AND the symlinks to said directories, if you have been following the pattern described above. |
There was a problem hiding this comment.
Make this extraneously clear, spell out everything here, as well.
| docker build -f plugin_builder.centos7.Dockerfile -t irods-plugin-builder:centos-7 . | ||
| docker build -f plugin_builder.ubuntu16.Dockerfile -t irods-plugin-builder-42s:ubuntu-16.04 . | ||
| docker build -f plugin_builder.ubuntu18.Dockerfile -t irods-plugin-builder-42s:ubuntu-18.04 . | ||
| docker build -f plugin_builder.centos7.Dockerfile -t irods-plugin-builder-42s:centos-7 . |
There was a problem hiding this comment.
I only included these platforms because irods_python_ci_utilities only supports these platforms at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note about Docker Image tags in the instructions for building
the builders
Add more details about directory structures and naming schemes as it
relates to the build and test hooks for iRODS plugins as these use a
specific system for package discovery and installation