Skip to content

Conversation

@minrk
Copy link
Member

@minrk minrk commented Oct 20, 2025

also fixes %matplotlib osx which gets converted to macosx on its way through matplotlib and back

This should hopefully be the regression test for #1458

@minrk
Copy link
Member Author

minrk commented Oct 20, 2025

all the matplotlib tests are passing on mac and windows, need to figure out why linux isn't enabling the event loops

and increase timeout for tk
@ccordoba12
Copy link
Member

need to figure out why linux isn't enabling the event loops

Perhaps you need to run that test with xvfb?

@minrk
Copy link
Member Author

minrk commented Oct 20, 2025

Perhaps you need to run that test with xvfb?

Probably right, looking at that.

@ianthomas23
Copy link
Collaborator

Changes look good to me, and tests pass locally on both macos and linux. I don't understand the CI failures but I assume they are related to xvfb? Matplotlib itself pip installs pytest-xvfb which might be worth a try as with it installed pytest automatically uses xvfb without having to set the PRE_TEST stuff.

@minrk
Copy link
Member Author

minrk commented Oct 22, 2025

with xvfb, the tests are hanging after embed_kernel, which makes me think it might be during setup of test_eventloops

@ianthomas23
Copy link
Collaborator

Is it worth just disabling the reliably-failing test_matplotlib_eventloops.py on qt5/python3.14 so we can merge and come back to this later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants