Skip to content

[2431] unit test #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[2431] unit test #2432

wants to merge 2 commits into from
+1,603 −43

Conversation

SuchitraSwain
Copy link
Contributor

@SuchitraSwain SuchitraSwain commented Sep 11, 2025 •
edited by lidel
Loading

lidel and others added 2 commits August 28, 2025 21:34
@lidel
fix: macos input focus issue in draggable regions
01f5c1e 
port fix from ipfs/ipfs-desktop#2983 to ensure interactive elements
(inputs, buttons, selects) work properly within electron's
draggable regions by setting app-region: no-drag

this resolves left-click focus issues on macos where inputs
were not receiving focus due to pointer events being blocked
[2431] Unit tesst
059ee32
@SuchitraSwain SuchitraSwain requested a review from a team as a code owner September 11, 2025 20:54
@lidel
Copy link
Member

lidel commented Sep 17, 2025

Thank you for the contribution, but these tests aren't suitable for merging:

  1. Everything is mocked - All components and dependencies are replaced with mocks, so tests only verify mock behavior, not actual functionality
  2. Wrong testing library - Uses @testing-library/react which isn't in our dependencies
  3. No real coverage - Tests like "renders without crashing" with fully mocked components don't catch real bugs
  4. Unrelated to issue - References authentication/Firebase features that don't exist in ipfs-webui

Good tests should test actual component behavior and integration. These tests would add maintenance burden without improving code quality or catching regressions.

If you'd like to contribute meaningful tests, please:

  • Test real component logic without mocking everything
  • Follow existing test patterns in the codebase
  • Focus on actual ipfs-webui functionality

@lidel lidel closed this Sep 17, 2025
@lidel lidel mentioned this pull request Sep 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: update unit test case
2 participants
@SuchitraSwain @lidel