Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add hint about basic http auth for rpc #2338

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: add hint about basic http auth for rpc #2338

merged 1 commit into from
Feb 25, 2025

Conversation

2color
Copy link
Member

@2color 2color commented Feb 25, 2025

Context

This PR expands on ipfs/ipfs-docs#2000 and aims to provide a hint that you can pass basic HTTP auth credentials in the webui.

@2color 2color requested a review from a team as a code owner February 25, 2025 12:32
@welcome Welcome
Copy link

welcome bot commented Feb 25, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@2color 2color requested a review from lidel February 25, 2025 12:32
@lidel lidel changed the title Add hint about basic http auth for rpc fix: add hint about basic http auth for rpc Feb 25, 2025
@lidel lidel merged commit 7d00889 into main Feb 25, 2025
21 checks passed
@lidel lidel deleted the add-auth-pointer branch February 25, 2025 20:11
ipfs-gui-bot pushed a commit that referenced this pull request Feb 25, 2025
@semantic-release-bot
chore(release): 4.5.0 [skip ci]
b7b94c2 
## [4.5.0](v4.4.2...v4.5.0) (2025-02-25)

 CID `bafybeiata4qg7xjtwgor6r5dw63jjxyouenyromrrb4lrewxrlvav7gzgi`

 ---

### Features

* add QR Code to ShareModal ([#2320](#2320)) ([5dbccfd](5dbccfd))

### Bug Fixes

* add hint about basic http auth for rpc ([#2338](#2338)) ([7d00889](7d00889))
* **ci:** cluster pinning with timeout and retry ([#2321](#2321)) ([9007e98](9007e98))
* **ci:** typo in ci.yml ([7fbb51b](7fbb51b))
* **peers:** chrome regression and update ipfs-geoip to v9.2 ([#2333](#2333)) ([699f735](699f735))

### Trivial Changes

* add console warning ([#2332](#2332)) ([76a0c52](76a0c52))
* **deps:** bump actions/setup-go from 4 to 5 ([#2221](#2221)) ([412b89f](412b89f))
* pull transifex translations ([#2331](#2331)) ([e62b487](e62b487))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2color @ipfs-gui-bot @lidel