Fix PeerManager mutex bottleneck #875
Draft
+183
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
force-pushed
the
fix-pm-mutex-bottleneck
branch
2 times, most recently
from
7c0ca2e to
f9be3f2
Compare
gammazero
force-pushed
the
fix-pm-mutex-bottleneck
branch
from
8bb481e to
7b97171
Compare
Do not try to acquire a MessageQueue mutex while holding the PeerManager mutex. A MessageQueue mutex may already be held for message processing and waiting for these will delay releasing the global PeerManager mutex. Instead, start goroutines to update the MessageQueue asynchronously so that the PeerManager lock can be released sooner.
gammazero
force-pushed
the
fix-pm-mutex-bottleneck
branch
from
7b97171 to
bc94cda
Compare
Watch staging metrics for now. There is not any "linearizing the execution" since the code passed to the chanqueue was already serialized by the MessageQueue My bigger concern is that now there are 2 more goroutines per peer, so if this does not reduce waiting goroutines then it actually can make things worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to acquire a MessageQueue mutex while holding the PeerManager mutex. A MessageQueue mutex may already be held for message processing and waiting for these will delay releasing the global PeerManager mutex. Instead, enqueue calls to MessageQueue and let an asynchronous goroutine execute the calls so that the PeerManager lock can be released sooner, without having to wait for the MessageQueue operations.
In short, this decouples the PeerManager from the per-peer MessageQueue mutexes.
Kubo PR: ipfs/kubo#10749