Changed project framework versions and cleaned code. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and cleaned code.
|
Normally I would say that this much code cleanup not done by VS autoformat needs a dedicated PR. However, since there are no other known PRs in the works, this is fine and shouldn't cause any conflicts. Since CI isn't set up here yet, I'll need to pull this down manually and test that everything works. |
Arlodotexe
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Everything builds okay. @richardschneider created extensive unit tests, which are currently failing with 0.0.13 and can be updated over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1