Enable nullable globally and fix issues #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption where nullability covers it to reduce runtime code (this is a change to public surface area - can be reverted). Some opportunistic code cleanup.
This was referenced Mar 31, 2023
Derrick-
previously approved these changes
Apr 3, 2023
There was a problem hiding this comment.
This is great work. Takes care of a lot of null issues, Upgrades string.Format to string interpolation. Eliminates some unnecessary accessors.
It's a .Net version upgrade: most of the null features are introduced in C# 8.
(I had to look some of them up)
I am confident this is a good improvement to the project.
Arlodotexe
previously approved these changes
Apr 12, 2023
Arlodotexe
reviewed
Apr 12, 2023
|
This will publish as soon as it merges, for use in ipfs-shipyard/net-ipfs-http-client#21 |
|
@Arlodotexe your review was reset so this never committed or published. When done I'll push a dependency update to ipfs-shipyard/net-ipfs-http-client#21 |
|
Whoops! Sorry about that, let's kick it off. |
Arlodotexe
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #19 . Remove some ArgumentNullException where nullability covers it to reduce runtime code (this is a change to public surface area, can be reverted - see changes in unit tests). Some opportunistic code cleanup ahead of #9 .