Skip to content

Change const Eigen::Matrix& to Eigen::ConstRef<Matrix> #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025
Merged

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Mar 30, 2025

Description

Change const Eigen::Matrix& to Eigen::ConstRef<Matrix> for better compatibility and fewer copies.

Drop scalar templating in:

  • local_to_global
  • CollisionStencil::dof
  • CollisionStencil::vertices

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

How Has This Been Tested?

Existing unit tests.

Test Configuration:

  • OS and Version: macOS 15.3.2
  • Compiler and Version: Apple Clang 16.0.0

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.45%. Comparing base (9c56d11) to head (aaca2d4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/collisions/normal/normal_collision.cpp 25.00% 3 Missing ⚠️
src/ipc/broad_phase/spatial_hash.cpp 50.00% 1 Missing ⚠️
src/ipc/collisions/normal/normal_collision.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   96.36%   96.45%   +0.09%     
==========================================
  Files         102      102              
  Lines        7758     7760       +2     
==========================================
+ Hits         7476     7485       +9     
+ Misses        282      275       -7     
Flag Coverage Δ
unittests 96.45% <91.37%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus zfergus merged commit 159fd8f into main Mar 30, 2025
32 checks passed
@zfergus zfergus deleted the eigen-ref branch March 30, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant