Windows #50
Windows #50
Conversation
|
Blocked by #51 |
Codecov Report
@@ Coverage Diff @@
## develop #50 +/- ##
========================================
Coverage 62.75% 62.75%
========================================
Files 23 23
Lines 1893 1893
Branches 507 507
========================================
Hits 1188 1188
Misses 226 226
Partials 479 479
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #50 +/- ##
===========================================
- Coverage 67.06% 66.15% -0.92%
===========================================
Files 21 20 -1
Lines 1245 1179 -66
Branches 293 279 -14
===========================================
- Hits 835 780 -55
- Misses 128 139 +11
+ Partials 282 260 -22
Continue to review full report at Codecov.
|
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
src/community/mod.rs
Outdated
| Some(self.peer.get_sha1()?.to_vec()) | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Expected an indentation at 8 instead of at 6.
src/community/mod.rs
Outdated
| Some(self.peer.get_sha1()?.to_vec()) | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Unexpected trailing spaces found.
So that it's easier to catch errors
| # channels to enable unstable features when building for nightly. Or you could add additional | ||
| # matrix entries to test different combinations of features. | ||
| environment: | ||
| matrix: |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
|
|
||
| ### MSVC Toolchains ### | ||
|
|
||
| # Stable 64-bit MSVC |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
|
|
||
| # Stable 64-bit MSVC | ||
| - channel: stable | ||
| target: x86_64-pc-windows-msvc |
There was a problem hiding this comment.
Expected an indentation at 8 instead of at 6.
|
|
||
| ### GNU Toolchains ### | ||
|
|
||
| # Stable 64-bit GNU |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
|
|
||
| # Stable 64-bit GNU | ||
| - channel: stable | ||
| target: x86_64-pc-windows-gnu |
There was a problem hiding this comment.
Expected an indentation at 8 instead of at 6.
| # default-toolchain and default-host manually here. | ||
| install: | ||
| - appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe | ||
| - rustup-init -yv --default-toolchain %channel% --default-host %target% |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| install: | ||
| - appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe | ||
| - rustup-init -yv --default-toolchain %channel% --default-host %target% | ||
| - set PATH=%PATH%;%USERPROFILE%\.cargo\bin |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| - appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe | ||
| - rustup-init -yv --default-toolchain %channel% --default-host %target% | ||
| - set PATH=%PATH%;%USERPROFILE%\.cargo\bin | ||
| - rustc -vV |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| - rustup-init -yv --default-toolchain %channel% --default-host %target% | ||
| - set PATH=%PATH%;%USERPROFILE%\.cargo\bin | ||
| - rustc -vV | ||
| - cargo -vV |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| #directly or perform other testing commands. Rust will automatically be placed in the PATH | ||
| # environment variable. | ||
| test_script: | ||
| - cargo test --verbose %cargoflags% |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| # channels to enable unstable features when building for nightly. Or you could add additional | ||
| # matrix entries to test different combinations of features. | ||
| environment: | ||
| matrix: |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
|
|
||
| ### MSVC Toolchains ### | ||
|
|
||
| # Stable 64-bit MSVC |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
|
|
||
| # Stable 64-bit MSVC | ||
| - channel: stable | ||
| target: x86_64-pc-windows-msvc |
There was a problem hiding this comment.
Expected an indentation at 8 instead of at 6.
|
|
||
| ### GNU Toolchains ### | ||
|
|
||
| # Stable 64-bit GNU |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
|
|
||
| # Stable 64-bit GNU | ||
| - channel: stable | ||
| target: x86_64-pc-windows-gnu |
There was a problem hiding this comment.
Expected an indentation at 8 instead of at 6.
| # default-toolchain and default-host manually here. | ||
| install: | ||
| - appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe | ||
| - rustup-init -yv --default-toolchain %channel% --default-host %target% |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| install: | ||
| - appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe | ||
| - rustup-init -yv --default-toolchain %channel% --default-host %target% | ||
| - set PATH=%PATH%;%USERPROFILE%\.cargo\bin |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| - appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe | ||
| - rustup-init -yv --default-toolchain %channel% --default-host %target% | ||
| - set PATH=%PATH%;%USERPROFILE%\.cargo\bin | ||
| - rustc -vV |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| - rustup-init -yv --default-toolchain %channel% --default-host %target% | ||
| - set PATH=%PATH%;%USERPROFILE%\.cargo\bin | ||
| - rustc -vV | ||
| - cargo -vV |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| #directly or perform other testing commands. Rust will automatically be placed in the PATH | ||
| # environment variable. | ||
| test_script: | ||
| - cargo test --verbose %cargoflags% |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| #directly or perform other testing commands. Rust will automatically be placed in the PATH | ||
| # environment variable. | ||
| test_script: | ||
| - cd rust_ipv8 |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
| test_script: | ||
| - cd rust_ipv8 | ||
| - cargo test --verbose %cargoflags% | ||
| - cd rust_ipv8 |
There was a problem hiding this comment.
Expected an indentation at 4 instead of at 2.
still not sure about travis vs. appveyor
|
Windows still seems to be having networking problems |
|
Code Climate has analyzed commit 7fa2ae1 and detected 13 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.