Allow Features in Implicit Accounts #604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allow features in implicit accounts because they allow for more seamless implicit account creation. The more permutations of Basic Outputs we allow implicit account creation addresses in, the more seamless implicit account creation becomes.
On the other hand, Storage Deposit Return, Timelock and Expiration Unlock Condition are not useful for implicit account creation, so they continue to be disallowed.
Return Address
would not be an implicit account creation address, but probably a regualrEd25519 Address
. Then for theAddress
the Basic Output would be an implicit account, but for theReturn Address
it would be a regular output, which is very undesirable behavior.How the change has been tested
Added new tests for where implicit account creation addresses are allowed.