Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel #56

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Parallel #56

merged 2 commits into from
Apr 3, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 14, 2024 •
edited
Loading

Implements a parallel job execution for the different metrics. We lose the independent error log for the services we query but we can keep that as a debug mode only in the test suit.

Ported from #54:

  • Parallelize update_metrics
    TODO (moved to National platforms #57):
  • HF Radar Stations # This is a hardcoded number in the notebook (165), is that still valid @MathewBiddle?
  • National Platforms # Lots of services and should be into a separate module
  • NGDAC Glider Days # Implemented but must change to glider-data-days

This was referenced Feb 15, 2024
Merged
Merged
ocefpaf added 2 commits April 3, 2024 18:16
@ocefpaf
add regional_platforms, ott_projects, qartod, ioos_core_variables, me…
f2e1fc5 
…tadata_records, ioos, mbon_projects, and hab_pilot_projects and refactor tests
@ocefpaf
update conda-lock
1cee559
@ocefpaf ocefpaf marked this pull request as ready for review April 3, 2024 16:32
MathewBiddle
MathewBiddle approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Did you run through black too? More legible now. Thanks!

@MathewBiddle MathewBiddle merged commit d19e7b5 into ioos:main Apr 3, 2024
1 check passed
@ocefpaf ocefpaf deleted the parallel branch April 3, 2024 18:53
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 3, 2024

All looks good. Did you run through black too? More legible now. Thanks!

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathewBiddle MathewBiddle MathewBiddle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @MathewBiddle