feat(datetime): re-emit wheel ionScrollStart/ionScrollEnd from picker columns #30674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-emit ionScrollStart/ionScrollEnd from wheel columns on ion-datetime by capturing inner ion-picker-column events and suppressing originals; coalesce multiple concurrent column scrolls into a single start/end with a 300ms end debounce add ionScrollStart/ionScrollEnd to ion-picker-column and emit at scroll start/end update API/types and Angular/Vue proxies to expose new events stabilize prefer-wheel specs by replacing fake timers with real waits to avoid newSpecPage timeouts closes ionic-team#30449
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30449
What is the current behavior?
Wheel scrolling inside ion-datetime does not provide host-level lifecycle events for app code to react to start/end of scrolling.
What is the new behavior?
Does this introduce a breaking change?
Other information
Verification
Targeted specs: cd core && npm ci && npm run test.spec -- src/components/datetime/test/prefer-wheel/datetime.spec.ts (expect 3 passed).
Manual: cd core && npm start, open /src/components/datetime/test/prefer-wheel/index.html.
Scroll a wheel column: app receives one ionScrollStart at the beginning, one ionScrollEnd after settling.