fix(modal): dismiss modal when parent element is removed from DOM #30544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…numbers of grandparents being removed, causing the modal to be removed by nothing to observe it
…d when a containing component is removed
ShaneK
force-pushed
the
fix/remove-modal-when-parent-removed
branch
from
c8b29f1 to
6923e03
Compare
ShaneK
force-pushed
the
fix/remove-modal-when-parent-removed
branch
from
6923e03 to
c95edd9
Compare
ShaneK
force-pushed
the
fix/remove-modal-when-parent-removed
branch
from
c95edd9 to
ed19c14
Compare
brandyscarney
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30389
What is the current behavior?
Currently, when the element an ion-modal was presented from is removed, the modal stays presented and can be broken depending on the framework. This is unlike #30540, where children of open modals were being kept open. In this case, specifically the DOM element is being removed for whatever reason and the modal is staying open.
What is the new behavior?
We're now identifying our parent component on load and watching it with a mutation observer to determine if it gets removed from the DOM. If it does, we trigger a dismiss. This, conveniently, works nicely with #30540 and will dismiss all children and grandchildren as well.
Does this introduce a breaking change?
Other information
The issue this resolves was already marked closed, but on closer inspection I determined that was a mistake. I believed this issue was related to another one I was dealing with and it is, but it wasn't quite the same.
After this issue is merged, I believe we will have handled all avenues of possibly ending up with broken modals because of parent elements or modals being removed.
Relevant Test Page
Current dev build: