Skip to content

chore(git): improve Ionitron to stop closing issues that have the 'needs: investigation' label #30424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2025
Merged

chore(git): improve Ionitron to stop closing issues that have the 'needs: investigation' label #30424

merged 5 commits into from
Jun 2, 2025

Conversation

gnbm
Copy link
Contributor

@gnbm gnbm commented May 25, 2025

Issue number: internal

What is the current behavior?

  • Currently, Ionitron is closing issues when they have the needs: investigation label.
  • We might want to use the duplicate ticket as our source of truth since a community member has made a suggestion that could fix it.

What is the new behavior?

  • The ionic-issue-bot.yml file was changed to stop closing issues that have the needs: investigation label
  • To prevent Ionitron from closing issues with the needs: investigation label, we've added this label to the exemptLabels list under the stale, noReply, and noReproduction sections.
  • This tells the bot not to close issues with that label, even if they meet the criteria for being stale or lacking a reply/reproduction.

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • N.A.

@gnbm gnbm requested a review from a team as a code owner May 25, 2025 14:37
@gnbm gnbm added the package: core @ionic/core package label May 25, 2025
@gnbm gnbm requested a review from christian-bromann May 25, 2025 14:37
@vercel Vercel
Copy link

vercel bot commented May 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 3:13pm

@github-actions github-actions bot removed the package: core @ionic/core package label May 25, 2025
@gnbm gnbm changed the title chore(): improve Ionitron to stop closing issues that have the 'needs: investigation' label chore(git): improve Ionitron to stop closing issues that have the 'needs: investigation' label May 25, 2025
@gnbm gnbm added the type: feature request a new feature, enhancement, or improvement label May 25, 2025
brandyscarney
brandyscarney reviewed May 28, 2025
View reviewed changes
brandyscarney
brandyscarney reviewed May 28, 2025
View reviewed changes
@brandyscarney brandyscarney removed the type: feature request a new feature, enhancement, or improvement label May 28, 2025
@gnbm gnbm requested a review from brandyscarney June 2, 2025 15:27
thetaPC
thetaPC approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnbm gnbm added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit c62590a Jun 2, 2025
50 checks passed
@gnbm gnbm deleted the FW-6542 branch June 2, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC thetaPC approved these changes

@christian-bromann christian-bromann Awaiting requested review from christian-bromann christian-bromann is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnbm @brandyscarney @thetaPC