refactor(datetime): update ionic styles for footer buttons #30014
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Nov 12, 2024
| @@ -13,7 +13,7 @@ | |||
| // -------------------------------------------------- | |||
|
|
|||
| ::slotted(*) .button-clear { | |||
| --color: globals.$ion-primitives-neutral-1200; | |||
| --color: #{globals.$ion-primitives-neutral-1200}; | |||
There was a problem hiding this comment.
Noticed this while updating the styles.
thetaPC
commented
Nov 12, 2024
Comment on lines
163
to
179
| :host .datetime-action-buttons ion-buttons { | ||
| display: flex; | ||
|
|
||
| justify-content: space-between; | ||
| } | ||
|
|
||
| /** | ||
| * The confirm and clear buttons are grouped in a | ||
| * container so that they appear on the end opposite | ||
| * of the cancel button. | ||
| * We use display: flex so that the | ||
| * wrapper only takes up as much | ||
| * height as it needs. | ||
| */ | ||
| .datetime-action-buttons .datetime-action-buttons-container { | ||
| display: flex; | ||
| } |
There was a problem hiding this comment.
These only apply to the native styles.
| // ----------------------------------- | ||
|
|
||
| :host .datetime-buttons ion-buttons { | ||
| display: block; |
There was a problem hiding this comment.
Suggested change
| display: block; | |
| display: flex; | |
| flex-flow: column; | |
| align-items: stretch; | |
| gap: globals.$ion-space-250; |
If you want to implement this in a different way that's fine but it looks like there is a gap in Figma between buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The footer buttons (confirm, clear, and cancel) do not match the ionic theme styles.
What is the new behavior?
ionic.ionic.Does this introduce a breaking change?
Other information
Preview