Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(segment): fix flaky gesture test and re-enable #30008

Merged
merged 1 commit into from
Nov 8, 2024
Merged

test(segment): fix flaky gesture test and re-enable #30008

merged 1 commit into from
Nov 8, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Nov 8, 2024

Issue number: internal


What is the current behavior?

There's a flaky test that was disabled for segment. It's been known that gesture tests are prone to be flaky.

What is the new behavior?

  • Fixed the test by switching to the improved dragElementBy function

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 6:47pm

@github-actions github-actions bot added the package: core @ionic/core package label Nov 8, 2024
@thetaPC thetaPC marked this pull request as ready for review November 8, 2024 19:11
@thetaPC thetaPC requested a review from a team as a code owner November 8, 2024 19:11
@thetaPC thetaPC added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 3216108 Nov 8, 2024
48 checks passed
@thetaPC thetaPC deleted the ROU-5434 branch November 8, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants