feat(select-modal): add ionic theme styling #30007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Nov 7, 2024
Comment on lines
-79
to
-82
| :host(.ion-focused) .item-native { | ||
| // This prevents the focus ring from clipping. | ||
| overflow: visible; | ||
| } |
There was a problem hiding this comment.
No longer needed and it was interfering with the focus ring.
thetaPC
commented
Nov 7, 2024
Comment on lines
+98
to
+104
| --border-width: #{globals.$ion-border-size-0 globals.$ion-border-size-0 globals.$ion-border-size-025 | ||
| globals.$ion-border-size-0}; | ||
| } | ||
|
|
||
| :host(.item-lines-inset) { | ||
| --inner-border-width: #{globals.$ion-border-size-0} #{globals.$ion-border-size-0} #{globals.$ion-border-size-025} #{globals.$ion-border-size-0}; | ||
| --inner-border-width: #{globals.$ion-border-size-0 globals.$ion-border-size-0 globals.$ion-border-size-025 | ||
| globals.$ion-border-size-0}; |
There was a problem hiding this comment.
Just moved the variables to use only one #{}
thetaPC
commented
Nov 7, 2024
Comment on lines
+162
to
+168
| .label-text-wrapper { | ||
| text-overflow: ellipsis; | ||
|
|
||
| white-space: nowrap; | ||
|
|
||
| overflow: hidden; | ||
| } |
There was a problem hiding this comment.
Noticed that the select options weren't truncating with ellipsis. Moved this to common since every theme behaves the same.
tanner-reits
requested changes
Nov 8, 2024
There was a problem hiding this comment.
I believe the radios should be hidden for single-select (like we do for MD theme)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ion-select-modaldoes not have styles forionictheme.What is the new behavior?
ionicthemeNo changes were made to the other interfaces. Those will continue to follow the current styles.
Does this introduce a breaking change?
Other information
Preview