feat(css): add CSS utility classes to the ionic theme bundle to match other themes #29974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
force-pushed
the
bc/test-remove-default-bundle
branch
from
9cdef3a
to
57f7487
Compare
brandyscarney
commented
Oct 28, 2024
There was a problem hiding this comment.
This file includes the CSS utilities documented here: https://ionicframework.com/docs/layout/css-utilities
2 tasks
brandyscarney
requested review from
christian-bromann,
BenOsodrac,
thetaPC and
tanner-reits
and removed request for
christian-bromann
BenOsodrac
requested changes
Oct 29, 2024
BenOsodrac
approved these changes
Oct 29, 2024
brandyscarney
force-pushed
the
bc/test-remove-default-bundle
branch
from
5fae4cc
to
b1588bf
Compare
brandyscarney
commented
Oct 29, 2024
Comment on lines
+146
to
+147
| const defaultSpaceUtilityClasses = generateDefaultSpaceUtilityClasses(); | ||
| otherUtilityClasses.push(defaultSpaceUtilityClasses); |
There was a problem hiding this comment.
These were the only lines added - the rest is formatting
brandyscarney
changed the title
brandyscarney
changed the title
|
Requesting re-review because I changed the scope of this PR. |
BenOsodrac
approved these changes
Oct 29, 2024
|
LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
ionictheme includes the default (iOS/MD) bundle in the tests. Additionally, theionictheme bundle is missing CSS utility classes provided by the default bundle, so removing that bundle causes issues in several tests.What is the new behavior?
The default bundle is removed from the tests for the
ionictheme because it adds global component styles that theionictheme does not need. The missing utility files are imported, and padding/margin classes are generated from the design tokens, as many tests rely onion-paddingandion-text-centerbeing available. This update ensures theionictheme includes the same classes offered in our documentation: https://ionicframework.com/docs/layout/css-utilities.Does this introduce a breaking change?