-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backdrop): remove tabindex for improved accessibility #29956
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
We have just upgraded from version 6, and considering the compatibility of user terminals, we cannot upgrade to version 8 at the moment. May I ask if there is any way to solve the issue with version 7 |
@zhuchenghuFF Support for version 7 ended on October 17, 2024, which is why this fix was not implemented for version 7. Upgrading to the latest release is highly recommended. |
Hi, We don't have any issue with Ionic 7 and Angular 17. Since our Angular migration, we encounter the aria-hidden problem with Ionic 7 (We know that is not officially compatible) ; pay attention that this not occur when using inline modal (backdrop reacts correctly without any aria blocked event). Kr. |
Hi @thetaPC , We cannot close with backdrop click any of overlay components (Alert, Loading, Modal) due to aria issue. We are planning to migrate to 8.x but we need some time. Kr. |
@TiBz0u Thanks for reaching out! We have a strict policy regarding support for past versions, and since maintenance for v7 officially ended on October 17, 2024, we are unable to make any further patches. For continued support, improvements, and fixes, we highly recommend upgrading to v8 as soon as possible. |
Issue number: resolves #29773
What is the current behavior?
Certain Chrome and Edge versions (confirmed: Chrome v127 and Edge v127) would indicate that the backdrop has an accessibility violation:
The error is happening because
tabindex
andaria-hidden
are being passed toion-backdrop
. Thetabindex
attribute is used to make an element focusable, regardless of value. Whenaria-hidden
is applied to an element, then the element is hidden from screen readers. This violates the accessibility standards sinceion-backdrop
would be considered a focusable element but not visible to screen readers.What is the new behavior?
tabindex
, this aligns with frameworks known for accessibility (Chakra UI)Does this introduce a breaking change?
Other information
Dev build:
8.3.4-dev.11729533091.1ac77a0c
How to test:
main
branchROU-11175
branch