Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toast): implement new shapes #29936

Merged
merged 10 commits into from
Oct 18, 2024
Merged

feat(toast): implement new shapes #29936

merged 10 commits into from
Oct 18, 2024

Conversation

OS-pedrolourenco
Copy link

Issue number: internal

What is the current behavior?

The shape of the toast component could not be customized.

What is the new behavior?

  • I have introduced a new shape property which determines whether the toast widget has soft, round or rectangular corners.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@OS-pedrolourenco OS-pedrolourenco requested a review from a team as a code owner October 14, 2024 14:40
@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package labels Oct 14, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:18pm

@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 15, 2024
tanner-reits
tanner-reits approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work 💪 Just one small request, but doesn't impact functionality so won't make it a blocker

core/src/components/toast/toast.tsx Show resolved Hide resolved
@thetaPC thetaPC changed the title feat(modal): implement new shapes for ion-toast feat(toast): implement new shapes Oct 16, 2024
@thetaPC
Copy link
Contributor

thetaPC commented Oct 16, 2024

@OS-pedrolourenco I updated the PR title. It had feat(modal) which is incorrect since the PR is for toast. Plus I removed the redundant mention of toast, it's not needed since the target component is already in the scope.

thetaPC
thetaPC requested changes Oct 16, 2024
View reviewed changes
core/src/components/toast/test/shape/index.html Show resolved Hide resolved
core/src/components/toast/test/shape/toast.e2e.ts Outdated Show resolved Hide resolved
core/src/components/toast/test/shape/toast.e2e.ts Outdated Show resolved Hide resolved
core/src/components/toast/test/shape/toast.e2e.ts Outdated Show resolved Hide resolved
core/src/components/toast/toast.tsx Show resolved Hide resolved
core/src/components/toast/toast.tsx Outdated Show resolved Hide resolved
thetaPC
thetaPC requested changes Oct 17, 2024
View reviewed changes
core/src/components/toast/toast.tsx Outdated Show resolved Hide resolved
core/src/components/toast/toast.tsx Outdated Show resolved Hide resolved
core/src/components/toast/toast.tsx Outdated Show resolved Hide resolved
core/src/components/toast/toast.tsx Outdated Show resolved Hide resolved
core/src/components/toast/toast.tsx Show resolved Hide resolved
@gnbm gnbm requested a review from thetaPC October 17, 2024 21:52
thetaPC
thetaPC requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on the changes I requested, once those are applied, please request me for another review. Thanks.

thetaPC
thetaPC approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OS-pedrolourenco OS-pedrolourenco merged commit d8bdf39 into next Oct 18, 2024
46 checks passed
@OS-pedrolourenco OS-pedrolourenco deleted the ROU-11265 branch October 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner-reits tanner-reits tanner-reits approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OS-pedrolourenco @thetaPC @tanner-reits