docs(react): show complete code context in the "Your First App" tutorial #4201
Conversation
|
@joesphchang is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
I noticed that some method names from the Angular version and Vue version do not match even though they have the same code. For example, addNewToGallery from Angular and usePhotoGallery from Vue. Let's also sync those to match Angular as close as possible.
The same goes for the <title>. Let's match it to Angular.
Lastly, some of the content also doesn't match each other. A good example, Angular Build Your First App mentions:
`ion-header` represents the top navigation and toolbar, with "Tab 2" as the title (there are two of them due to iOS [Collapsible Large Title](https://ionicframework.com/docs/api/title#collapsible-large-titles) support). Rename both ion-title elements to:
While React states:
`IonHeader` represents the top navigation and toolbar, with "Tab 2" as the title. Let’s rename it:
There was a problem hiding this comment.
There's a code block that has the following comment: <!-- some filler -->. This needs to be replaced to be the entire code. Review this PR for how it should be.
2 participants
Resolves: #4164
Changes:
Update code blocks in first 5 pages of ReactPhoto App tutorial to show additional context for each step with comments to indicate new lines.