feat: Implement cordova plugin #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which contains a bugfix for openDocumentFromLocalPath
OS-pedrogustavobilro
requested review from
andredestro,
ItsChaceD and
alexgerardojacinto
ItsChaceD
requested changes
Mar 25, 2025
ItsChaceD
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the cordova plugin with the following methods:
openDocumentFromLocalPathopenDocumentFromResourcesopenDocumentFromUrlpreviewMediaContentFromLocalPathpreviewMediaContentFromResourcespreviewMediaContentFromUrlAlso implement an
outsystems-wrapperlayer that can consume the cordova or capacitor plugin (whichever is defined).Notes
The plugin is only implemented on Android and iOS, because the Outsystems consumer has its own implementation for PWA.
While the
previewMediaContentFrom(...)methods are offered for iOS only, Android defaults to usingopenDocumentFrom(...)methods. We don't return an error here to maintain the same behavior as the current cordova plugin.Tests
Used a "NewFileSampleApp" on Outsystems O11 that uses this plugin - Tested native Android, iOS, and PWA.