added new video parameters and new aar - #11
Conversation
| = true // Should we save the recorded video persistently or not | ||
| private var includeMetadata = | ||
| false // Should we allow the app to obtain metadata about the media item | ||
| private var editParameters = IONCAMREditParameters( |
There was a problem hiding this comment.
Is it ok to remove these values? I had problems with this before but maybe this isn't needed anymore
There was a problem hiding this comment.
I think it’s safe to remove the default values since editParameters is always initialized right before use, so we don’t rely on a default instance anymore, from the tests I’ve done so far, I haven’t run into any issues.
Do you remember what kind of issues you had before? If you have more details, I can try to replicate it to make sure I'm not missing anything
There was a problem hiding this comment.
After analysis, and given you mentioned that you have issues with this, I think is better to keep editParameters initialized with default values at class level. Removing it would require carefully controlling its value before every call to callEditPhoto and callEditURIPhoto, which adds complexity and risk. To keep things safe and predictable at this stage, I'd prefer not to change this behaviour for now.
same for ionic-team/capacitor-camera#17
| args.getJSONObject(0).getBoolean(INCLUDE_METADATA), | ||
| args.getJSONObject(0).optBoolean(IS_PERSISTENT, true) | ||
| ) | ||
| callCaptureVideo(videoParameters!!) |
There was a problem hiding this comment.
Do we need the force-unwrap? Could we use a let instead?
There was a problem hiding this comment.
yeah, we can change this to a let. I used a force unwrap because we create videoParameters right before calling captureVideo, so it will always exist, but I can change it.
There was a problem hiding this comment.
ok yeah if we can use a let instead aI think it would be better
2 participants
No description provided.