fix(android): native lib causes app compilation to fail #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-martacarlos
approved these changes
Jan 14, 2025
alexgerardojacinto
approved these changes
Jan 14, 2025
IT-MikeS
pushed a commit
that referenced
this pull request
Jan 15, 2025
## [1.0.3](v1.0.2...v1.0.3) (2025-01-15) ### Bug Fixes * **android:** native lib causes app compilation to fail ([#42](#42)) ([8a57a22](8a57a22)) * **android:** Unknown Kotlin JVM target 21 ([#41](#41)) ([78245bc](78245bc)) * Remove unnecessary permissions from AndroidManifest.xml ([#39](#39)) ([a7218d5](a7218d5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using OSInAppBrowserLib-Android with 1.x plugin, that assumes Capacitor 7 compileSdk 34, causes apps to fail compilation due to transitive dependencies requiring compileSdk 35:
By using
@aar, the transitive dependencies are no longer passed to the plugin / app.This would cause issues if some of the dependencies were missing, but they're all declared by capacitor, and using different version didn't affect the native Android app at all, from my tests.