fix: resolve node handle misalignment during live edits#363
Closed
jainarjav80-sys wants to merge 3 commits into
Closed
fix: resolve node handle misalignment during live edits#363jainarjav80-sys wants to merge 3 commits into
jainarjav80-sys wants to merge 3 commits into
Conversation
Author
|
Hey @AgniveshChaubey & @jagpreetrahi, could you please review this PR whenever have some time |
Contributor
Preview Deployed!
Last updated at 2026-07-10T18:12:35Z |
| updateNodeInternals(id); | ||
| }, 0); | ||
| return () => clearTimeout(timer); | ||
| }, [handleOffsets, id, updateNodeInternals]); |
Member
There was a problem hiding this comment.
It doesn't look like this solution is working. I can still see the same issue when editing schema. Please make sure to test your solution properly locally.
Author
|
@AgniveshChaubey Good catch! The issue was that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where React Flow connection lines (edges) become visually misaligned when a node's internal dimensions or row positions change dynamically during live schema editing.
What kind of change does this PR introduce
Bug fix
Issue Number
Closes #338
Screenshots/Video
before :
after :
Does this PR introduce a breaking change?
No. This is a targeted UI fix to ensure React Flow recalculates node internals correctly.
If relevant, did you update the documentation?
No documentation updates were necessary.